feat(react-drawer): make dialog slot to be used for composition only #29392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l-to-composition * master: feat: FlatTree supports navigation without useHeadlessFlatTree (microsoft#29091) fix(react-card): sync controllable state for selectable cards (microsoft#29276) fix (microsoft#29275)
* master: fix(react-dialog): use makeResetStyles for base dialog components styles (microsoft#29280) chore(react-tags-preview): update props descriptions (microsoft#29287) chore: bump swc core to mitigate transpilation memory leaks (microsoft#29253) feat: adds customizeSelector to createCustomFocusIndicatorStyle method (microsoft#29209) applying package updates Updated TooltipBestPractices to include accessibility best practices (microsoft#29284) fix: BreadcrumbItem should use makeResetStyles for base styles (microsoft#29278)
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4d0a102:
|
.../react-components/react-dialog/src/components/DialogSurface/useDialogSurfaceStyles.styles.ts
Show resolved
Hide resolved
.../react-components/react-drawer/src/components/DrawerOverlay/useDrawerOverlayStyles.styles.ts
Show resolved
Hide resolved
* master: (49 commits) remove a11y test ux from theme designer (microsoft#29379) feat: preview release (microsoft#29377) Fixed divider in the tooltip (microsoft#29357) fix (microsoft#29376) docs: Initial documentation pass (microsoft#29372) feat: Integrate Announce context (microsoft#29362) chore(react-tags): stable release (microsoft#29355) chore: delegate focus outline to layout components (microsoft#29293) Vertical bar chart line bug (microsoft#29299) applying package updates Adding axis title examples for line, area, vertical bar and vertical stacked bar charts (microsoft#29254) A11y: Pagination: Add tooltip for all icon buttons (microsoft#29155) A11y: Fix aria attribute for page number and add correct role (microsoft#29349) feat: Implement motion for MessageBar (microsoft#29339) feat: creates getIntrinsicElementProps to replace getNativeElementProps on slots creation (microsoft#29310) chore: replace makeStyles with makeResetStyles (microsoft#29338) applying package updates ci(github/policies): remove bot rules that created and added `Component/Package $1`: labels on PRs (microsoft#29301) fix: handle multiple classes in PortalCompatProvider (microsoft#29351) applying package updates ...
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 631 | 609 | 5000 | |
| Button | mount | 312 | 325 | 5000 | |
| Field | mount | 1117 | 1080 | 5000 | |
| FluentProvider | mount | 695 | 699 | 5000 | |
| FluentProviderWithTheme | mount | 73 | 87 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 73 | 64 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 78 | 77 | 10 | |
| InfoButton | mount | 14 | 13 | 5000 | |
| MakeStyles | mount | 850 | 862 | 50000 | |
| Persona | mount | 1799 | 1707 | 5000 | |
| SpinButton | mount | 1398 | 1356 | 5000 |
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 8eee0cd4867ef5a44628bc7b7bf5f6a41b2a6dba (build) |
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
bsunderhus
reviewed
Oct 4, 2023
change/@fluentui-react-dialog-04ca4ed5-a856-4939-b505-9951b07b9816.json
Outdated
Show resolved
Hide resolved
packages/react-components/react-drawer/src/components/DrawerOverlay/DrawerOverlay.types.ts
Outdated
Show resolved
Hide resolved
...ents/react-drawer/src/components/DrawerOverlay/DrawerOverlaySurface/DrawerOverlaySurface.tsx
Outdated
Show resolved
Hide resolved
bsunderhus
requested changes
Oct 4, 2023
Contributor
bsunderhus
left a comment
bsunderhus
left a comment
There was a problem hiding this comment.
Let's wait for this PR to be merged #29396
.../react-components/react-drawer/src/components/DrawerOverlay/useDrawerOverlayStyles.styles.ts
Show resolved
Hide resolved
packages/react-components/react-drawer/src/components/DrawerOverlay/useDrawerOverlay.ts
Show resolved
Hide resolved
…nts/DialogSurface/index.ts
…nts/DialogSurface/useDialogSurfaceStyles.styles.ts
…505-9951b07b9816.json
bsunderhus
approved these changes
Oct 5, 2023
ValentinaKozlova
approved these changes
Oct 5, 2023
* master: fix: screenreader narration improvements (microsoft#29404) chore: Adds VR tests for MessageBar (microsoft#29405) Fixing the issue Going from stack callout to single callout and back to stack callout still shows the single callout (microsoft#29324)
layershifter
reviewed
Oct 6, 2023
...er/src/components/DrawerOverlay/DrawerOverlaySurface/useDrawerOverlaySurfaceStyles.styles.ts
Outdated
Show resolved
Hide resolved
layershifter
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
DrawerOverlay was using DialogSurface as is using React's composition.
New Behavior
Rewrite and split DrawerOverlay to use our internal composition API.